Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop init.d support and go-daemon binaries #6174

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: drop init.d support and go-daemon binaries #6174

wants to merge 5 commits into from
+2 −734

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Dec 2, 2024

What does this PR do?

remove init.d scripts
drop go-daemon dep and daemon binaries
cleanup mage tasks

Why is it important?

Similar to elastic/beats#41845

init.d should not be needed on distros we support
According to go-daemon readme: "Go daemon is not needed on systems with systemd."

See https://www.elastic.co/support/matrix#matrix_os

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@kruskall
feat: drop init.d support and go-daemon binaries
a86673e 
remove init.d scripts
drop go-daemon dep and daemon binaries
cleanup mage tasks
@kruskall kruskall requested a review from a team as a code owner December 2, 2024 05:28
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 2, 2024
@kruskall kruskall added enhancement New feature or request skip-changelog labels Dec 2, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Dec 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/drop-go-daemon upstream/feat/drop-go-daemon
git merge upstream/main
git push upstream feat/drop-go-daemon

kaanyalti
kaanyalti previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@kaanyalti kaanyalti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, but I don't have enough context here, if someone else can look at it as well it would be better.

@cmacknz
Copy link
Member

cmacknz commented Dec 6, 2024

This is fine as long as the DEB and RPM packages still run as services. That there is no replacement systemd unit file added here makes me think we may have broken something. I see the DEB tests are failing now, so that is one potential reason.

We create out existing systemd service in Go code right now so there isn't an easy way to extract it without refactoring that.

elastic-agent/internal/pkg/agent/install/svc.go

Line 84 in 54932dc

if runtime.GOOS == "linux" {

blakerouse
blakerouse requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is possible because it is true that on DEB/RPM that we do not support any OS that uses sysvinit. But there is clearly an issue with the upgrade path for the deb packages.

Interested to determine what you find on why that is not working with these changes. I am going to mark this as "Request changes" only, because I was to review it again before its merged with that fixed.

@cmacknz
Copy link
Member

cmacknz commented Feb 14, 2025

There is an actual bug related to us continuing to include init.d files now #6704

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @kruskall

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse requested changes

@kaanyalti kaanyalti kaanyalti left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@kruskall kruskall

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kruskall @elasticmachine @cmacknz @blakerouse @kaanyalti @pierrehilbert